-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump iOS minimum version in podspec to support Xcode 14.3 #761
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Remember to also bump the podspec version to 1.6.1 or 1.7.0 before publishing to CocoaPods trunk. My recommendation without full context would be 1.6.1 to make it as seamless as possible for clients to get the update.
If the version bump affected Xcodes that are still currently be used, I would agree that it needs to be a minor version update. Since this is changing from a long ago version to a still unsupported version, I think a patch version update is better so that clients that lock to a minor version also get the fix without a respin of their podspec or Podfile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after the version bump is handled, thanks!
Fixes #759